Skip to content

Task/Plot and Input controls motion fix #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2025
Merged

Task/Plot and Input controls motion fix #35

merged 5 commits into from
Oct 31, 2025

Conversation

@RajeshwriK
Copy link
Contributor

@RajeshwriK RajeshwriK commented Oct 28, 2025 •
edited
Loading

Two changes are being addressed here:

  1. Plots were not moving to visible screen when active or highlighted
  2. Input container was always aligning to center and hiding some controls when used in a single column mode

@RajeshwriK RajeshwriK self-assigned this Oct 28, 2025
@RajeshwriK RajeshwriK added the bug Something isn't working label Oct 28, 2025
@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

Summary

Summary
Generated on: 10/31/2025 - 06:03:01
Coverage date: 10/31/2025 - 06:00:23
Parser: Cobertura
Assemblies: 15
Classes: 40
Files: 40
Line coverage: 8.5% (317 of 3696)
Covered lines: 317
Uncovered lines: 3379
Coverable lines: 3696
Total lines: 6336
Branch coverage: 4.9% (33 of 666)
Covered branches: 33
Total branches: 666
Method coverage: Feature is only available for sponsors
Tag: 109_18964150061

Coverage

kic-script-gen.src.back_end - 0%
Name Line Branch
kic-script-gen.src.back_end 0% 0%
kic-script-gen.src.back_end.client_server.rs 0% 0%
kic-script-gen.src.back_end.data_model.rs 0% 0%
script-aggregator.src - 0%
Name Line Branch
script-aggregator.src 0% 0%
script-aggregator.src.indent_engine.rs 0% 0%
script-aggregator.src.script_buffer.rs 0% 0%
script-gen-manager.src - 0%
Name Line Branch
script-gen-manager.src 0% 0%
script-gen-manager.src.catalog.rs 0%
script-gen-manager.src.device.rs 0% 0%
script-gen-manager.src.instr_metadata - 0%
Name Line Branch
script-gen-manager.src.instr_metadata 0% ****
script-gen-manager.src.instr_metadata.base_metadata.rs 0%
script-gen-manager.src.instr_metadata.enum_metadata.rs 0%
script-gen-manager.src.instr_metadata.mpsu50_metadata.rs 0%
script-gen-manager.src.instr_metadata.msmu60_metadata.rs 0%
script-gen-manager.src.model.chan_data - 0%
Name Line Branch
script-gen-manager.src.model.chan_data 0% 0%
script-gen-manager.src.model.chan_data.bias_channel.rs 0% 0%
script-gen-manager.src.model.chan_data.channel_range.rs 0% 0%
script-gen-manager.src.model.chan_data.default_channel.rs 0% 0%
script-gen-manager.src.model.chan_data.region_map.rs 0% 0%
script-gen-manager.src.model.chan_data.start_stop_channel.rs 0% 0%
script-gen-manager.src.model.chan_data.step_channel.rs 0%
script-gen-manager.src.model.chan_data.sweep_channel.rs 0%
script-gen-manager.src.model.sweep_data - 0%
Name Line Branch
script-gen-manager.src.model.sweep_data 0% 0%
script-gen-manager.src.model.sweep_data.global_parameters.rs 0%
script-gen-manager.src.model.sweep_data.number_limit.rs 0% 0%
script-gen-manager.src.model.sweep_data.parameters.rs 0% 0%
script-gen-manager.src.model.sweep_data.status_msg.rs 0%
script-gen-manager.src.model.sweep_data.step_sweep_config.rs 0%
script-gen-manager.src.model.sweep_data.sweep_config.rs 0% 0%
script-gen-manager.src.model.sweep_data.sweep_model.rs 0%
script-gen-manager.src.model.sweep_data.sweep_timing_config.rs 0%
script-gen-manager.src.script_component - 0%
Name Line Branch
script-gen-manager.src.script_component 0% 0%
script-gen-manager.src.script_component.data_report.rs 0%
script-gen-manager.src.script_component.finalize.rs 0%
script-gen-manager.src.script_component.function.rs 0% 0%
script-gen-manager.src.script_component.initialize.rs 0% 0%
script-gen-manager.src.script_component.script.rs 0% 0%
script-gen-manager.src.script_component.sweep.rs 0% 0%
xml-handler.src - 0%
Name Line Branch
xml-handler.src 0% ****
xml-handler.src.generic_parser.rs 0%
xml-handler.src.composite - 25%
Name Line Branch
xml-handler.src.composite 25% 8.8%
xml-handler.src.composite.mod.rs 25% 8.8%
xml-handler.src.condition - 70.9%
Name Line Branch
xml-handler.src.condition 70.9% 50%
xml-handler.src.condition.mod.rs 70.9% 50%
xml-handler.src.group - 41.6%
Name Line Branch
xml-handler.src.group 41.6% 14.2%
xml-handler.src.group.mod.rs 41.6% 14.2%
xml-handler.src.resources - 0%
Name Line Branch
xml-handler.src.resources 0% ****
xml-handler.src.resources.mod.rs 0%
xml-handler.src.snippet - 44.3%
Name Line Branch
xml-handler.src.snippet 44.3% 50%
xml-handler.src.snippet.mod.rs 44.3% 50%
xml-handler.src.substitute - 71.4%
Name Line Branch
xml-handler.src.substitute 71.4% ****
xml-handler.src.substitute.mod.rs 71.4%
xml-handler.src.variable - 63.6%
Name Line Branch
xml-handler.src.variable 63.6% 58.8%
xml-handler.src.variable.mod.rs 75.6% 58.3%
xml-handler.src.variable.sub_mod.rs 48.9% 60%

@RajeshwriK RajeshwriK marked this pull request as ready for review October 30, 2025 07:02
@RajeshwriK RajeshwriK requested a review from a team as a code owner October 30, 2025 07:02
esarver
esarver approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@esarver esarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RajeshwriK RajeshwriK merged commit 81188e7 into main Oct 31, 2025
16 checks passed
@RajeshwriK RajeshwriK deleted the task/TSP-1182 branch October 31, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esarver esarver esarver approved these changes

Assignees

@RajeshwriK RajeshwriK

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RajeshwriK @esarver @jharajeev55